10000 feat: set target_commitish when creating a GitHub release by wingyplus · Pull Request #305 · semantic-release/github · GitHub
[go: up one dir, main page]

Skip to content

feat: set target_commitish when creating a GitHub release #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

wingyplus
Copy link
Contributor
@wingyplus wingyplus commented Nov 16, 2020

Closes #304

@gr2m
Copy link
Member
gr2m commented Nov 16, 2020

can you please rebase on latest master? We just fixed the CI setup.

Change looks good, but can you please adapt the tests accordingly?

@wingyplus wingyplus changed the title Set git_commitish when creating GitHub release feat: set target_commitish when creating a GitHub release Nov 17, 2020
@wingyplus
Copy link
Contributor Author
wingyplus commented Nov 17, 2020

@gr2m Test was added and commit message change to follows the pattern. :)

Copy link
Member
@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@gr2m gr2m merged commit a54e596 into semantic-release:master Nov 17, 2020
@github-actions
Copy link

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wingyplus wingyplus deleted the iss-304 branch November 18, 2020 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set branch name to target_commitish
3 participants
0