8000 feat: deprecate github search api consumption by babblebey · Pull Request #1037 · semantic-release/github · GitHub
[go: up one dir, main page]
Skip to content

feat: deprecate github search api consumption #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: beta
Choose a base branch
from
Draft

feat: deprecate github search api consumption #1037

wants to merge 5 commits into from
+6 −360

Conversation

babblebey
Copy link
Member
@babblebey babblebey commented Apr 28, 2025 •
edited by hearts bot
Loading

This PR completely removes the consumption of the github search API from the plugin; following its relegation in #907 and the deprecation notice of the endpoint itself from github.

Related Issue

Fixes #1022

@MikeMcC399 MikeMcC399 mentioned this pull request May 30, 2025
Open
@travi travi changed the base branch from master to beta July 3, 2025 19:32
@travi
Copy link
Member
travi commented Jul 3, 2025 •
edited by hearts bot
Loading

@babblebey since this will be a breaking change, i retargeted this PR at the beta release branch that i created today to go along with the existing work for the npm plugin and for the core package to consume these betas.

what do you consider to be the current state of this change? do you have much more to do for this to be ready to merge?

@babblebey
Copy link
Member Author
babblebey commented Jul 3, 2025 •
edited by hearts bot
Loading

Targeting at beta sounds good. In terms of getting this through, there's not much... I'll round this up in a bit.

Out of context, but the OIDC work is the work you meant when you mentioned the NPM plugin works, right!? 🤔

@travi
Copy link
Member
travi commented Jul 3, 2025 •
edited
Loading

Out of context, but the OIDC work is the work you meant when you mentioned the NPM plugin works, right!?

in this context, i just meant the beta of the npm plugin to get us to the latest major version. part of the motivation for that is for the upcoming oidc support for semantic-release/npm#958, but that is only just getting started. assuming it goes smoothly, i would like that support to be included in the upcoming major, but no guarantees yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning about /seach/issues GitHub API endpoint
2 participants
@babblebey @travi
0