8000 Replace mockito mocks with Hand-built test doubles · Issue #111 · seleniumQuery/seleniumQuery · GitHub
[go: up one dir, main page]
Skip to content

Replace mockito mocks with Hand-built test doubles #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
acdcjunior opened this issue Jan 23, 2016 · 1 comment
Closed

Replace mockito mocks with Hand-built test doubles #111

acdcjunior opened this issue Jan 23, 2016 · 1 comment
Labels
scope:internal-only
Milestone
0.11.0

Comments

@acdcjunior
Copy link
Member

250~ unit tests are taking about 5s to run which is toooooo long.

I want to remove mockito hoping that time goes down and also as an experience on hand-built test doubles "maintenance scalability".
acdcjunior added a commit that referenced this issue Jan 23, 2016
@acdcjunior
#111 Begun replacing mockito with hand-built test doubles
87f40e6
acdcjunior added a commit that referenced this issue Jan 23, 2016
@acdcjunior
#111 Test doubles should not have constructor called outside package
cd8ce98
acdcjunior added a commit that referenced this issue Jan 23, 2016
@acdcjunior
#111 Further removal of mockito usages
4d00ab0
acdcjunior added a commit that referenced this issue Jan 23, 2016
@acdcjunior
#111 Removed all calls to mock(WebDriver.class)
0a77c19
acdcjunior added a commit that referenced this issue Jan 24, 2016
@acdcjunior
#111 Just method renaming
c80ef32
acdcjunior added a commit that referenced this issue Jan 24, 2016
@acdcjunior
#111 Removed mockito usage at ElementFinderUtilsTest
cf2cada
acdcjunior added a commit that referenced this issue Jan 24, 2016
@acdcjunior
#111 Removed mockito usage at Log injection testing classes
10595f0
acdcjunior added a commit that referenced this issue Jan 24, 2016
@acdcjunior
#111 Removed mockito altogether - closes
f3e5355
@acdcjunior
Copy link
Member Author

Time went down from ~5s to ~2.8s.
I did have to write some quite elaborated test doubles (mostly dummies and stubs, but there was some spies and a "real" mock).
I will keep the experiment for the moment.

@acdcjunior acdcjunior added this to the 0.11.0 milestone Jan 31, 2016
acdcjunior added a commit that referenced this issue Dec 15, 2017
@acdcjunior
#111 Begun replacing mockito with hand-built test doubles
ca96181
acdcjunior added a commit that referenced this issue Dec 15, 2017
@acdcjunior
#111 Test doubles should not have constructor called outside package
59b0556
acdcjunior added a commit that referenced this issue Dec 15, 2017
@acdcjunior
#111 Further removal of mockito usages
c79a5ef
acdcjunior added a commit that referenced this issue Dec 15, 2017
@acdcjunior
#111 Removed all calls to mock(WebDriver.class)
d687d9f
acdcjunior added a commit that referenced this issue Dec 15, 2017
@acdcjunior
#111 Just method renaming
9e59db6
acdcjunior added a commit that referenced this issue Dec 15, 2017
@acdcjunior
#111 Removed mockito usage at ElementFinderUtilsTest
3364606
acdcjunior added a commit that referenced this issue Dec 15, 2017
@acdcjunior
#111 Removed mockito usage at Log injection testing classes
d7bff69
acdcjunior added a commit that referenced this issue Dec 15, 2017
@acdcjunior
#111 Removed mockito altogether - closes 5105
6e289b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope:internal-only
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
1 participant
@acdcjunior
0