This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Merged
Conversation
Required to run zap on non docker (e.g. containerd clusters) Also updated the used zap image
nigthknight
approved these changes
Sep 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds integration tests for the ZAP integration.
While adding these i've made some other improvements to improve the stability and debuggability of the tests:
ttlSecondsAfterFinishedproperty on scanJobs configurable. Kind seems to already have the ttlAfterFinished controller running even thought its still an alpha feature. When this is enable its harder to log print logs of failing scanner containers as they might already be deleted.containerdcluster.