8000 Add Cronjob Configuration Options and Fix Security Context for Nuclei Chart by J12934 · Pull Request #801 · secureCodeBox/secureCodeBox · GitHub
[go: up one dir, main page]
Skip to content

Add Cronjob Configuration Options and Fix Security Context for Nuclei Chart #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
J12934 merged 4 commits into from
Nov 10, 2021
Merged

Add Cronjob Configuration Options and Fix Security Context for Nuclei Chart #801

J12934 merged 4 commits into from
Nov 10, 2021

Conversation

@J12934
Copy link
Member
@J12934 J12934 commented Nov 9, 2021

Description

Was having some problems with the nuclei CronJobs on a "not so healthy" kubernetes cluster.
Would have liked to have access to these added options to tweak the behavior of this CronJob.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@J12934 J12934 added the enhancement New feature or request label Nov 9, 2021
@J12934 J12934 self-assigned this Nov 9, 2021
@J12934
Expose history limit configs via helm values
34bd81c 
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934
Add configurable concurency policy and set the default concurrencyPolicy
77dae5d 
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934 J12934 force-pushed the feature/configure-nuclei-cronjob branch from c839c94 to dcb21a0 Compare November 10, 2021 10:12
@J12934
Add proper docs to added values
cd56ae4 
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934 J12934 force-pushed the feature/configure-nuclei-cronjob branch from dcb21a0 to cd56ae4 Compare November 10, 2021 10:12
malexmave
malexmave previously approved these changes Nov 10, 2021
View reviewed changes
@J12934
Change back runAsNonRoot to false and disable readOnly FS 😕
6f3a122 
Nuclei image IS running as root and needs to write to the /tmp folder...

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934 J12934 changed the title Add Cronjob Configuration Options to Nuclei Chart Add Cronjob Configuration Options and Fix Security Context for Nuclei Chart Nov 10, 2021
@J12934 J12934 added the bug Bugs label Nov 10, 2021
@J12934 J12934 enabled auto-merge November 10, 2021 12:06
@J12934 J12934 merged commit f1a4ee4 into main Nov 10, 2021
@J12934 J12934 deleted the feature/configure-nuclei-cronjob branch November 10, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malexmave malexmave malexmave approved these changes

Assignees

@J12934 J12934

Labels

bug Bugs enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@J12934 @malexmave
0