🚧 [Consistency] Making all values.yaml files consistent #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Replaced some unnecessary comments 2. Added xy.xyz.zxy descriptions to all values 3. Added security context to all scanners 4. Added cascading rules to all scanners (when no cascading rules exist, they are set to false) 5. Changed nuclei image tag from "latest" to "null" 6. Set RunAsNonRoot for whatweb from "false" to "true" 7. ncrack, zap/zap-advanced have some special settings that have not been touched Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
…nsistency/value-files
This is necessary because the provided amass container has a non-numeric user that cannot be verified to be root or not: Error: container has runAsNonRoot and image has non-numeric user (user), cannot verify user is non-root (pod: "scan-amass-scanner-dummy-scan, container: amass) Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
A non-numeric user cannot be checked to be non-root by Kubernetes and causes an error if runAsNonRoot is (justifiably) activated. Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Like Kubehunter Dockerfile, non-root user is not needed Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Changes to USER did not yield the desired effect Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
For scanners: gitleaks, kube-hunter, ssh-scan, sslyze, trivy, wpscan, zap, zap-advanced Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
11 tasks
J12934
requested changes
Oct 13, 2021
Member
There was a problem hiding this comment.
Good changes 👍, but there were some cases where the differences are required, see below.
Contributor
Author
|
Well, since these are only comments I think it is debatable if this should be changed for every scanner individually or if the versioning system should be given another thought. (#716) |
This is because scb scanners use a different versioning system connected to the releases
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
This is because scb scanners use a different versioning system connected to the releases Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
…nsistency/value-files
Contributor
Author
|
We discussed the problem and it was concluded that the correct version should be used at the moment, but an issue for the inconsistent versioning has been created (#716). |
J12934
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #693.
Once applied, all values.yaml files for all scanners will follow the same template. The following changes have been made:
Note that in the amass values.yaml securityContext, runAsNonRoot had to be set to false, because their Dockerfile does not use a numeric value for their user.
Thus their user cannot be verified to be root or not:
Error: container has runAsNonRoot and image has non-numeric user (user), cannot verify user is non-root (pod: "scan-amass-scanner-dummy-scan, container: amass). (See #715)
Same unfortunately applies for even more scanners, see #723
Checklist