Adding integration tests for trivy security scanner #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing against a recent version of the juiceshop from dockerhub Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
nigthknight
reviewed
Sep 20, 2021
Member
There was a problem hiding this comment.
I'm not quite sure how volatile this test is because of new discovered vulnerabilities. What do you think @J12934 , @rseedorff ?
Member
|
Yeah good point, might be better to have it be a "at least this amount of findings" check, as its bound to go up in the future. |
This should ensure a more stable test result due to the older version Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
This will not let the tests failed when new vulnerabilities are found Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
nigthknight
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon merging, this PR will add integration tests for the trivy security scanner.
This will close #623.
Contrary to what has been discussed there, downloading the database for trivy during the integration tests does not seem to be an issue. The tests took only about 35s.
Successful download of the database has also been stated in the trivy logs.
If the tests prove to be unstable, however, it could be considered to add an offline version of the trivy database as described here. This would pose the need for a scanner dockerfile created by us instead of the official image, where a version of the database would be included. Integration tests could be run with the "--skip-update" flag afterwards.
Checklist
npm testruns for the whole project.