8000 Integrating pingcastle template, parser and tutorial with SCB (closes #388) by SebieF · Pull Request #574 · secureCodeBox/secureCodeBox · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@SebieF
Copy link
Contributor
@SebieF SebieF commented Aug 4, 2021

Description

This PR adds a template for integrating PingCastle with the secureCodeBox. It provides template files, a ready-to-use parser and an exhaustive tutorial on how to make it (probably) work.
It is the first windows scanner to get supported by the scb, a follow up blog post about the journey will follow soon.

Draft Open Issues:

  • Are template files okay?
  • Is the tutorial per se understandable and provides enough detail?
  • Does the parser cover all the aspects of the generated xml file?

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

(closes #388)

SebieF added 4 commits August 4, 2021 15:00
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
@SebieF SebieF added enhancement New feature or request scanner Implement or update a security scanner help wanted Extra attention is needed python Issues based on python implementations labels Aug 4, 2021
@SebieF SebieF self-assigned this Aug 4, 2021
SebieF and others added 2 commits August 4, 2021 15:20
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
@rfelber rfelber changed the title Integrating pingcastle template, parser and tutorial with scB (closes #388) Integrating pingcastle template, parser and tutorial with SCB (closes #388) Aug 7, 2021
SebieF added 2 commits August 10, 2021 13:25
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
SebieF added 6 commits August 30, 2021 11:19
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
@SebieF SebieF marked this pull request as ready for review August 30, 2021 09:35
@SebieF SebieF requested a review from rfelber September 6, 2021 08:56
SebieF and others added 7 commits September 7, 2021 13:14
1. Replacing all ' with "
2. Replacing incorrect scanner image ".Chart.Version" with ".Chart.AppVersion"
3. Replacing array command for ncrack, nmap, test-scan, whatweb with single lines for each parameter
4. Removing redundant comments
5. Adding missing empty lines
6. Make order of variables consistent for all scanners

Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
This is done because these are our own scanners (SCB scanners) that follow our release versioning system. Regarding consistency, an issue was created to keep this in mind.

Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
@SebieF
Copy link
Contributor Author
SebieF commented Oct 12, 2021

Instead of merging, pingcastle branch will be kept and linked to an experimental documentation side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Extra attention is needed python Issues based on python implementations scanner Implement or update a security scanner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚓 Integrate PingCastle as Active Directory Scanner

2 participants

0