Fix Helm Chart Build #319
Merged
Fix Helm Chart Build #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed that our current release process did not use the right docker images anymore. This problem was created after switching to the new build and push docker action because the images are now tagged with a valid semver instead of a version with a leading 'v' but the release tried to use the 'old' version style with a leading 'v'. To resolve this issue we decided to trim the leading 'v' in our Release Action because we want to have consistent tags in Github Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
f4e60ea to
3d01d5e
Compare
J12934
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that our current release process did not use the right docker
images anymore. This problem was created after switching to the new
build and push docker action because the images are now tagged with a
valid semver instead of a version with a leading 'v' but the release
tried to use the 'old' version style with a leading 'v'.
To resolve this issue we decided to trim the leading 'v' in our Release
Action because we want to have consistent tags in GitHub
Signed-off-by: Yannik Fuhrmeister yannik.fuhrmeister@iteratec.com