Migrate Scanner / Parsers to ESM and @kubernetes/client-node v1.x #3088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Reet00
approved these changes
Jul 15, 2025
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Nuclei parser has no dependencies, having them is not required and doesn't do anything Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Linking is done using the parser-sdk local file link from the scanners/ directory Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@owasp.org>
They aren't integrated in ci and the setup for them is unclear :/ They haven't run in over 3 years and apparently nobody misses them. All these scenarios are already covered by some of our normal hooks so these were always more basic tests.
This was just testing if the secret is there, overkill to do that in js. kubectl get secret <name> will fail if no resource exists with that name
Seems pretty much unused now. Linter would be good to bring back but doesn't work in it's current form :(
Migrate helm test running in ci to task
wasn't causing problems as bun can handle it, but its inconsistent
This reverts commit 399ec15.
…ind, kubectl and so on to avoid rate limits from github
Ensures that the jobs that are working keep running to easier identify if one of them is broken
overlooked this earlier and was confused why mocking was even working
cmsseek is pending removal: secureCodeBox#3117
Prior versions might not support all required features
cleanup should always run Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates all scanner and hooks to use ecma script modules for code im/exports.
This enables us to upgrade to the new @kubernets/client-node v1.x which only supports ESM (As many new modules do)
To be better able to test this, I've revamped / migrated the the local testing setup from makefiles to task files with (imo) way easier usage w/ automatic kind cluster / testing env setup.
for the hooks, I've reactivated the tests which were still in the global test/integration folder, these haven't been running for 2-3 years. There were also some generic integration tests which were also not in CI, these i've deleted because our normal test coverage for hooks and scanners have gotten so got that there is little point to them.
CI is reporting scanner status checks are missing, i've removed a duplicate space in the job name, that causes the confusion, everything should still be here.
Closes #2851
Closes #1158
Checklist