8000 Allow configuration of imagePullSecret for all trivy components by K4iM4k3r · Pull Request #2929 · secureCodeBox/secureCodeBox · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@K4iM4k3r
Copy link
Contributor
@K4iM4k3r K4iM4k3r commented Mar 5, 2025

Description

In order to use private registries which require authentication,n it is needed to configure imagePullSecrets for all parts. Some parts like trivy cache were missing the option to configure those

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

In order to use private registries which require authentication it is
needed to configure imagePullSecrets for all parts.

Signed-off-by: Kai Schäfer <kai.schaefer@de.clara.net>
@netlify
Copy link
netlify bot commented Mar 5, 2025

Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 37668ff
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/67cb0126f1cbd6000850aa46

@J12934
Copy link
Member
J12934 commented Mar 5, 2025

Awesome thanks, looks good on a first glance.Will have a closer look soon. 😊

@J12934 J12934 moved this from Triage to To Review in secureCodeBox Mar 5, 2025
@J12934 J12934 added the bug Bugs label Mar 5, 2025
@J12934 J12934 changed the title Helm chart trivy scanner - Allow configuration of imagePullSecret for all trivy components Allow configuration of imagePullSecret for all trivy components Mar 6, 2025
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@github-project-automation github-project-automation bot moved this from To Review to Reviewer Approved in secureCodeBox Mar 7, 2025
@sonarqubecloud
Copy link
sonarqubecloud bot commented Mar 7, 2025

@J12934 J12934 merged commit 8e10e4d into secureCodeBox:main Mar 7, 2025
53 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in secureCodeBox Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants

0