Encrypt Ncrack passwords (closes #209) #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f3e730 to
2fc8bf0
Compare
798cb43 to
85b730b
Compare
nigthknight
requested changes
Dec 2, 2020
Member
There was a problem hiding this comment.
Looks good so far. Only one spelling issue 👍
rfelber
reviewed
Dec 2, 2020
…ecureCodeBox/secureCodeBox into scanner/209-anonymize-ncrack-passwords
nigthknight
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an new configuration option to the Ncrack scanner.
The user is now able to encrypt password findings with a public key provided via kubernetes secrets.