8000 Add SPDX Header License Check To PRs by Zero3141 · Pull Request #1961 · secureCodeBox/secureCodeBox · GitHub
[go: up one dir, main page]
Skip to content

Add SPDX Header License Check To PRs #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Zero3141 merged 4 commits into from
Sep 29, 2023
Merged

Add SPDX Header License Check To PRs #1961

Zero3141 merged 4 commits into from
Sep 29, 2023

Conversation

@Zero3141
Copy link
Contributor
@Zero3141 Zero3141 commented Sep 15, 2023

Description

Fixes #957

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@Zero3141 Zero3141 added enhancement New feature or request ci Changes to the continuous integration setup labels Sep 15, 2023
@Zero3141 Zero3141 self-assigned this Sep 15, 2023
@netlify
Copy link
netlify bot commented Sep 15, 2023 •
edited
Loading

✅ Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 71bbb6c
🔍 Latest deploy log https://app.netlify.com/sites/docs-securecodebox/deploys/65158d2f3390af0008d1f607

@Zero3141 Zero3141 marked this pull request as draft September 15, 2023 09:16
@Zero3141
Copy link
Contributor Author
Zero3141 commented Sep 15, 2023 •
edited
Loading

At the moment, we have many files without a correct license header or license file. We should fix that before merging, otherwise the pipeline will always fail.

This was referenced Sep 15, 2023
Closed
Merged
@Zero3141 Zero3141 marked this pull request as ready for review September 26, 2023 13:48
Heiko Kiesel added 2 commits September 26, 2023 15:50
Add license check to CI
1013475 
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Remove repository restriction for testing
92b4588 
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
@Weltraumschaf Weltraumschaf enabled auto-merge (rebase) September 26, 2023 13:50
Undo changes for testing
c363ab4 
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
auto-merge was automatically disabled September 26, 2023 14:10

Rebase failed

@Zero3141 Zero3141 force-pushed the feature/ci-license-check branch from 7520114 to c363ab4 Compare September 26, 2023 14:41
@Zero3141 Zero3141 enabled auto-merge (rebase) September 26, 2023 14:42
@J12934 J12934 disabled auto-merge September 27, 2023 12:45
@Zero3141 Zero3141 merged commit f285b6f into secureCodeBox:main Sep 29, 2023
@Zero3141 Zero3141 deleted the feature/ci-license-check branch September 29, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Weltraumschaf Weltraumschaf Weltraumschaf approved these changes

Assignees

@Zero3141 Zero3141

Labels

ci Changes to the continuous integration setup enhancement New feature or request

Projects

secureCodeBox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Verify PRs for Correct SPDX Header in Main Repo

2 participants

@Zero3141 @Weltraumschaf
0