8000 Upgrade node version to current LTS by o1oo11oo · Pull Request #1853 · secureCodeBox/secureCodeBox · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@o1oo11oo
Copy link
Contributor
@o1oo11oo o1oo11oo commented Aug 7, 2023

Description

Change all occurences of node:16 to node:18 to upgrade to latest LTS. I haven't checked if this is fine for all parsers/hooks, so there might be some pipeline issues.

Fixes #1852.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

Fixes secureCodeBox#1852

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
@o1oo11oo o1oo11oo self-assigned this Aug 7, 2023
@o1oo11oo o1oo11oo added dependencies Pull requests that update a dependency file maintenance labels Aug 7, 2023
@o1oo11oo o1oo11oo merged commit 7c9aa7e into secureCodeBox:main Aug 8, 2023
@o1oo11oo o1oo11oo deleted the fix/upgrade-node branch August 8, 2023 12:01
o1oo11oo pushed a commit to o1oo11oo/secureCodeBox-documentation that referenced this pull request Sep 1, 2023
We upgraded our images to node 18 in secureCodeBox/secureCodeBox#1853,
this example file should mirror that.

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
Zero3141 pushed a commit to secureCodeBox/documentation that referenced this pull request Sep 4, 2023
We upgraded our images to node 18 in secureCodeBox/secureCodeBox#1853,
this example file should mirror that.

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
o1oo11oo pushed a commit to o1oo11oo/secureCodeBox that referenced this pull request Sep 5, 2023
Missed this node version when upgrading to latest LTS in secureCodeBox#1853

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
o1oo11oo pushed a commit to o1oo11oo/secureCodeBox that referenced this pull request Sep 8, 2023
Missed this node version as well when upgrading to latest LTS in secureCodeBox#1853

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
o1oo11oo pushed a commit to o1oo11oo/secureCodeBox that referenced this pull request Sep 11, 2023
Missed this node version when upgrading to latest LTS in secureCodeBox#1853

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
Ilyesbdlala pushed a commit to o1oo11oo/secureCodeBox that referenced this pull request Sep 12, 2023
Missed this node version when upgrading to latest LTS in secureCodeBox#1853

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
Ilyesbdlala pushed a commit that referenced this pull request Sep 12, 2023
Missed this node version when upgrading to latest LTS in #1853

Signed-off-by: Lukas Fischer <lukas.fischer@iteratec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file maintenance

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Containers still use node:16

2 participants

0