Added optional identified at parameter to findings
#1434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| eslint | 13 | 1 | 0.72s | ||
| misspell | 13 | 1 | 0.05s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
7aa23e0 to
b825b5a
Compare
53415d7 to
ef65d50
Compare
Member
|
Hi @Ilyesbdlala is this PR ready for review? |
Member
Author
Yes |
…ding This uses the amass's result Timestamp attribute This is done in relation to #519 Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…nding This uses the cmseek's `last_scanned` result attribute This is done in relation to #519 Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
… finding This uses the kubeaudit's `time` result attribute This is done in relation to #519 Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
This uses the ffuf's `time` result attribute This is done in relation to #519 Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…nding This uses the nuclei's `timestamp` result attribute This is done in relation to #519 Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…finding This uses the ssh-scan's `end-time` result attribute This is done in relation to #519 Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…nding This uses the sslyze `date_scans_completed` result attribute This is done in relation to #519 The tests are also converted from toContainEqual() to toMatchInlineSnapshot(), this is done to make maintenance easier and be inline with how we test our other scanners Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…nding This uses the wpscan `stop_time` result attribute This is done in relation to #519 Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…dards also fixed some formating Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
…n local machine and CI server I ran into an issue where the time coverted to ISO String was dependant from the timezone of the machine running the test. This means that if GitHub Actions CI time and local time are different the test will fail. To fix this UTC timezone is enforced in the date string. Sslyze uses UTC time zone internally already. However, CMSeek uses the timezone of the running machine. UTC was also chosen for simplicity and consistency. So times for Cmseek can be a few hours off Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
72b4313 to
b1530bf
Compare
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
identified at parameter to findingsidentified at parameter to findings
identified at parameter to findingsidentified at parameter to findings
rfelber
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
identified_atparameter to findings. It includes the time that a scan has occurred. This is done only to scanners that include the time of scan in their raw results.The format of the parameter is ISO8601
Partially resolves to #519
identified atadded to:Checklist