ADR 17: Enable container autodiscovery to scan images from private repos #1374
Conversation
MegaLinter status: ✅ SUCCESSSee errors details in artifact MegaLinter reports on CI Job page |
There was a problem hiding this comment.
Very nice work, thank you :) Only few minor comments from my side.
It might be worth to include the trivy operator and k8s scan functionality as an additional possibility? Other than that, I really like the sidecar proposal and that one is already very sophisticated thanks to your example!
I don think it is possible to incorporate the trivy operator into the scb as it functions differently. I looked at the trivy docs and added the idea to use ownerReferences to delete the secret after the scan is done to this adr. |
There was a problem hiding this comment.
LGTM. Did some suggestions.
|
@the-simmon Can't rebase. You must rebase by your own. |
7310228 to
f874476
Compare
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
f874476 to
fc9dd48
Compare
Done (I squashed all my commits into one because rebase did weird things because i renamed my file once) |
First draft, mostly brain storming, feel free to commit to this branch :) (this time with correct adr number)