Make ZAP-Advanced Default Config Volume Optional#1310
Merged
Conversation
#1289 changes the behaviour to always create the configmap. This was intentionally changed, to allow users to manage this configmap outside of helm. Marking this as optional allows scans without it to still work and keep this behaviour.
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ GIT | git_diff | yes | no | 0.14s | |
| ✅ PYTHON | bandit | 1 | 0 | 0.26s | |
| black | 1 | 1 | 0.46s | ||
| flake8 | 1 | 43 | 0.34s | ||
| isort | 1 | 1 | 0.11s | ||
| ✅ PYTHON | pylint | 1 | 0 | 1.48s | |
| misspell | 2 | 1 | 0.03s | ||
| prettier | 1 | 1 | 0.64s | ||
| ✅ YAML | v8r | 1 | 0 | 1.56s | |
| ✅ YAML | yamllint | 1 | 0 | 0.15s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
nigthknight
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative fix for #1289
#1289 changes the behaviour to always create the configmap. This was intentionally changed, to allow users to manage this configmap outside of helm.
Marking this as optional allows scans without it to still work and keep this behaviour.
Closes #1309
Closes #1289