Improved Megalint Config and applied auto fixes#1302
Merged
Conversation
We enable wanted linters, instead of disabling unwanted ones This results into not having multiple linters for each language, which is unneccesary and results into conflicts between linters Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Adding spaces between the brackets results in the helm charts failing Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Lint issues still exists that can't auto fixed but should be from so on resolved by the "leave it better than you found it" principle during development. Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 2 | 0 | 0.04s | |
| ✅ BASH | shfmt | 14 | 0 | 0.02s | |
| ✅ DOCKERFILE | hadolint | 1 | 0 | 0.12s | |
| golangci-lint | 5 | 5 | 11.91s | ||
| checkstyle | 2 | 2 | 5.17s | ||
| eslint | 5 | 1 | 0.8s | ||
| ✅ JSON | eslint-plugin-jsonc | 1 | 0 | 1.88s | |
| black | 36 | 1 | 1.43s | ||
| ✅ SPELL | misspell | 241 | 0 | 2.47s | |
| eslint | 1 | 1 | 0.46s | ||
| prettier | 176 | 1 | 11.58s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
Linter formatting of .test.js broke snapshot Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
J12934
approved these changes
Sep 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does the following:
Now should the Megalinter have a Warning in future PRs, the developer would know that it's either an issue that was newly introduced or an issue that could not at this time be auto-fixed, and should be manually resolved.
Replaces #1295. CI only looks failed due CodeClimate which is no longer used in Repo.
Closes https://github.com/secureCodeBox/internal/issues/83
Checklist