Update Various Go Package #1176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Hash is calculated for the entire object, so adding new fields to it changes the hash This will cause all scans created with `RetriggerOnScanTypeChange` to be recreated as the hash gets recalculated for the new fields Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
MegaLinter status:
|
| Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
|---|---|---|---|---|---|
| ✅ DOCKERFILE | dockerfilelint | 1 | 0 | 0.37s | |
| ✅ DOCKERFILE | hadolint | 1 | 0 | 0.07s | |
| ✅ GIT | git_diff | yes | no | 0.08s | |
| golangci-lint | 1 | 1 | 3.14s | ||
| ✅ GO | revive | 1 | 0 | 0.01s | |
| ✅ SPELL | misspell | 8 | 0 | 0.2s | |
| prettier | 6 | 1 | 4.64s | ||
| ✅ YAML | v8r | 6 | 0 | 4.15s | |
| yamllint | 6 | 1 | 7.91s |
See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
SebieF
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates golang packages for the operator and auto-discovery.
Resolves most usages of vulnerable version of protobuf lib: GHSA-c3h9-896r-86jm
Vulnerable version is still included transitivly via controller-runtime -> prometheus but these should not acutally be used and we might not be able to upgrade controller-runtime without a major / breaking release. See https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.12.0
With the updates I've also updated the kubernetes client libs. These introduced new fields to our crds as the new kubernetes version has new features. These new fields will also cause all ScheduledScans created with
RetriggerOnScanTypeChange=trueto be triggered, as the hash gets recalculated for the new fieldsChecklist
npm testruns for the whole project.