Migrate Zap Advanced to ZAPs new Reporting Addon #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Due to the placement of the ports section these would have been added to the last extraContainers entry, not on the sidecar Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Scan results are now written in its filesystem rather than the one of the zap-advanced-scan container Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
rfelber
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the Zap Advanced ScanType to use ZAPs new Reporting API.
This allows to properly scope the results to the configured context.
To allow this change we had to make some changes to the way results are passed to the secureCodeBox Lurker:
Previously the Results were fetched by the zap-advanced python script and written to disk. This is not possible with the new reporting addon as it only supports writing the report directly to disk and isn't returned in the api.
This limitation is worked around by mounting the zap-results volume also into the zap-sidecar so that zap can write the results directly to disk / the shared results volume.
Checklist
npm testruns for the whole project.