This repository was archived by the owner on Sep 6, 2023. It is now read-only.
Hook priority and selectors documentation #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 11, 2021 17:14
Signed-off-by: Jop Zitman <jop.zitman@secura.com>
…ex hook setups. Signed-off-by: Jop Zitman <jop.zitman@secura.com>
# Conflicts: # docs/contributing/integrating-a-hook/values.yaml.md
Signed-off-by: Jop Zitman <jop.zitman@secura.com>
This was referenced Nov 1, 2021
Closed
Signed-off-by: Jop Zitman <jop.zitman@secura.com>
malexmave
suggested changes
Nov 2, 2021
Member
There was a problem hiding this comment.
Thanks for writing this up. I have a few small change requests, listed below, but they should all be very quick to address. I also proposed a few small changes that are not part of your new content, but that fix errors in the docs that I spotted while going through your PR - I think it is easier to quickly address them inside this PR instead of going for a separate PR that will then require rebasing your branch.
Signed-off-by: Jop Zitman <jop.zitman@secura.com> Co-authored-by: Max Maass <malexmave@users.noreply.github.com>
malexmave
approved these changes
Nov 2, 2021
Member
There was a problem hiding this comment.
Great, thank you again. I'll leave this as approved, we can merge it once the two PRs on the main repo are merged (otherwise it will be deployed immediately and people will be confused 😁).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accompanies secureCodeBox/secureCodeBox#695 and secureCodeBox/secureCodeBox#757.
hookSelector