8000 Minor SMB/Kerberos improvements by gpotter2 · Pull Request #4749 · secdev/scapy · GitHub
[go: up one dir, main page]
Skip to content

Minor SMB/Kerberos improvements #4749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

Minor SMB/Kerberos improvements #4749

merged 1 commit into from
May 27, 2025

Conversation

gpotter2
Copy link
Member
@gpotter2 gpotter2 commented May 27, 2025 •
edited
Loading
  • minor additions to smbclient
  • minor fixes in Kerberos client in FAST mode when handling errors

@codecov Codecov
Copy link
codecov bot commented May 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 22.00000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 82.15%. Comparing base (8b002b6) to head (47be53d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/smbclient.py 17.77% 37 Missing ⚠️
scapy/fields.py 66.66% 1 Missing ⚠️
scapy/layers/kerberos.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4749      +/-   ##
==========================================
- Coverage   82.18%   82.15%   -0.04%     
==========================================
  Files         361      361              
  Lines       87227    87276      +49     
==========================================
+ Hits        71689    71702      +13     
- Misses      15538    15574      +36
Files with missing lines Coverage Δ
scapy/layers/smb2.py 88.11% <ø> (ø)
scapy/fields.py 92.87% <66.66%> (-0.05%) ⬇️
scapy/layers/kerberos.py 60.96% <50.00%> (+0.02%) ⬆️
scapy/layers/smbclient.py 70.95% <17.77%> (-3.01%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 merged commit b564a13 into secdev:master May 27, 2025
24 checks passed
@gpotter2 gpotter2 deleted the minor-krb branch May 27, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gpotter2
0