Allow DocBlock class to be called with built-in classes #4448
8000Conversation
Codecov Report
@@ Coverage Diff @@
## master #4448 +/- ##
============================================
+ Coverage 85.14% 85.16% +0.01%
- Complexity 4511 4520 +9
============================================
Files 243 243
Lines 12342 12350 +8
============================================
+ Hits 10509 10518 +9
+ Misses 1833 1832 -1
Continue to review full report at Codecov.
|
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it because the code in questions does not need support for built-in classes. The |
I agree, but PHPUnit uses that class internally quite often without prior check for built-in classes. In my case, the DeprecationErrorHandler from Symfony's PhpUnitBridge tries to find out if a triggered error originates from a test case of a certain group. It uses the Anyway, I think I can catch this case and prevent the call. Thanks for the quick heads-up. |
When being called on built-in classes like
DateTimeorReflectionClass, theDocBlockparser fails with obscure type errors. This happens because the reflection methodsgetStartLine(),getEndLine()andgetFileName()returnfalsefor those classes.Since there are no doc blocks to parse on those classes, I'd expect the parser to behave the same way as for a userland class without any doc blocks. This is what I've tried to achieve with this PR.