Fix for failed execution of npm install when run on Windows platforms#2020
Open
DimuDesigns wants to merge 13 commits intoscratchfoundation:developfrom
Open
Fix for failed execution of npm install when run on Windows platforms#2020DimuDesigns wants to merge 13 commits intoscratchfoundation:developfrom
npm install when run on Windows platforms#2020DimuDesigns wants to merge 13 commits intoscratchfoundation:developfrom
Conversation
…gle-closure-library' list
…re setting POWERSHELL_COMMAND_PREFIX
…tended comments for clarification
Open
…nstalled under Windows OS
…in 'powershell_path'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Fixes the recurring bug where the execution of
npm install, and subsequentlypython build.py, fails under Windows OS as cited by the following issues:Proposed Changes
Modified
build.pyto executegoogle-closure-compiler(initiated as a sub-process from Python) usingpowershell.exe. This eliminates the character limit constraint alluded to in the aforementioned issue reports.Reason for Changes
Compilation fails on windows machines during the build step. This fix resolves that issue.
Test Coverage
Executed the fix locally and it compiles successfully.