8000 MAINT: Fix pypy3 on CircleCI by larsoner · Pull Request #9700 · scipy/scipy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: Fix pypy3 on CircleCI #9700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2019
Merged

MAINT: Fix pypy3 on CircleCI #9700

merged 1 commit into from
Jan 19, 2019

Conversation

larsoner
Copy link
Member

Blindly trying the fix in numpy/numpy#12594

Closes #9691.

@larsoner larsoner force-pushed the pypy branch 3 times, most recently from 22f7e79 to 27d4734 Compare January 19, 2019 01:40
@larsoner
Copy link
Member Author

Okay CircleCI pypy3 variant passed. I've restarted all the CIs I killed to save time in case the pypy3 run failed. Someone feel free to have a look and (squash and) merge ASAP to get us back to green!

@larsoner larsoner changed the title WIP: pypy MAINT: Fix pypy3 on CircleCI Jan 19, 2019
This was referenced Jan 19, 2019
Closed
Closed
@larsoner larsoner added defect A clear bug or issue that prevents SciPy from being installed or used as expected maintenance Items related to regular maintenance tasks CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure labels Jan 19, 2019
@ilayn
Copy link
Member
ilayn commented Jan 19, 2019

All green, thank you for the emergency fix @larsoner

@ilayn ilayn merged commit 3cb8bd2 into scipy:master Jan 19, 2019
@larsoner
Copy link
Member Author

@pv I don't know where your comment went, but the env var was moved to $BASH_ENV so there was no longer the need to set it in every command

@larsoner larsoner deleted the pypy branch January 19, 2019 18:32
@mdhaber
Copy link
Contributor
mdhaber commented Jan 22, 2019

@larsoner
I got the issue reported in #9691 in #9676 an hour ago : /

export CCACHE_COMPRESS=1
export PATH=/usr/lib/ccache:$PATH
# Limit parallelism for Cythonization to 4 processes, to
# avoid exceeding CircleCI memory limits
export SCIPY_NUM_CYTHONIZE_JOBS=4
export NPY_NUM_BUILD_JOBS=`pypy3 -c 'import multiprocessing as mp; print(mp.cpu_count())'`
# Less aggressive optimization flags for faster compilation
OPT="-O1" FOPT="-O1" pypy3 setup.py build
Traceback (most recent call last):
  File "setup.py", line 488, in <module>
    setup_package()
  File "setup.py", line 420, in setup_package
    import numpy
  File "/usr/local/site-packages/numpy/__init__.py", line 142, in <module>
    from . import core
  File "/usr/local/site-packages/numpy/core/__init__.py", line 16, in <module>
    from . import multiarray
  File "/usr/local/site-packages/numpy/core/multiarray.py", line 44, in <module>
    arange.__module__ = 'numpy'
AttributeError: readonly attribute '__module__'
Exited with code 1

@ilayn
Copy link
Member
ilayn commented Jan 22, 2019

I don't understand why these don't fail all at once but one after the other as we fix them.

@larsoner
Copy link
Member Author

Did you rebase?

@larsoner
Copy link
Member Author

(Travis builds a merged version of each PR, Circle builds just the branch IIRC, unless you add custom code to the config to do a merge)

@mdhaber
Copy link
Contributor
mdhaber commented Jan 22, 2019

No, thanks. I'll try that.

pvanmulbregt pushed a commit to pvanmulbregt/scipy that referenced this pull request Jan 26, 2019
@larsoner @pvanmulbregt
MAINT: Fix pypy3 on CircleCI (scipy#9700)
c85f2df
@ilayn ilayn mentioned this pull request Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure defect A clear bug or issue that prevents SciPy from being installed or used as expected maintenance Items related to regular maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CircleCI tests failing on pypy3
3 participants
@larsoner @ilayn @mdhaber
0