MAINT: bump array-api submodules #22899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d14f8e6 to
579c474
Compare
crusaderky
commented
Apr 28, 2025
| @@ -614,7 +614,7 @@ def _kpp(data, k, rng, xp): | |||
| cumprobs = probs.cumsum() | |||
| r = rng.uniform() | |||
| cumprobs = np.asarray(cumprobs) | |||
| data_idx = np.searchsorted(cumprobs, r) | |||
| data_idx = int(np.searchsorted(cumprobs, r)) | |||
There was a problem hiding this comment.
This is a np.int64.
While legal in the Array API, this caused array-api-extra git tip to encroach on a bug of array-api-strict 2.3.1 (already fixed in array-api-strict git tip).
579c474 to
bc4de17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow_dask_compute=Trueinstead of 999 data-apis/array-api-extra#283