10000 BUG: `special.logsumexp` device propagation on PyTorch by crusaderky · Pull Request #22808 · scipy/scipy · GitHub
[go: up one dir, main page]
Skip to content

BUG: special.logsumexp device propagation on PyTorch #22808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

BUG: special.logsumexp device propagation on PyTorch #22808

merged 1 commit into from
Apr 7, 2025

Conversation

crusaderky
Copy link
Contributor
@crusaderky crusaderky commented Apr 7, 2025 •
edited
Loading

Bump array-api-compat to data-apis/array-api-compat#299

  • Fix input->output device propagation on PyTorch in scipy.special.logsumexp when the user has explicitly called torch.set_default_device (BUG: error for arrays on non-default device  #22680)
  • Run test_device on PyTorch in CI for
    • scipy.special.logsumexp
    • scipy.fft.fftfreq
    • scipy.fft.rfftfreq

@crusaderky crusaderky changed the title BUG: special.logsumexp device propagation on torch BUG: special.logsumexp device propagation on PyTorch Apr 7, 2025
@github-actions github-actions bot added scipy._lib defect A clear bug or issue that prevents SciPy from being installed or used as expected labels Apr 7, 2025
@crusaderky crusaderky requested a review from rgommers as a code owner April 7, 2025 09:57
@crusaderky crusaderky mentioned this pull request Apr 7, 2025
Open
lucascolley
lucascolley approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member
@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Guido!

@lucascolley lucascolley merged commit 41641c2 into scipy:main Apr 7, 2025
40 of 41 checks passed
@lucascolley lucascolley added this to the 1.16.0 milestone Apr 7, 2025
@crusaderky crusaderky deleted the torch_device branch April 7, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucascolley lucascolley lucascolley approved these changes

@rgommers rgommers Awaiting requested review from rgommers rgommers is a code owner

Assignees
No one assigned
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy._lib
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@crusaderky @lucascolley
0