ENH: stats.tvar/tstd/tsem: add array API support #21036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascolley
reviewed
Jun 24, 2024
|
I will push again once I fix the torch issues and confirm locally. (I have torch and JAX set up on my Mac, not this Windows machine, which has CuPy.) |
[skip cirrus] [skip circle]
j-bowhay
approved these changes
Jun 25, 2024
| def test_tmean(self, xp): | ||
| x = xp.asarray(X) | ||
| x = xp.asarray(X.tolist()) # use default dtype of xp |
There was a problem hiding this comment.
This is a neat trick I hadn't thought of doing this
There was a problem hiding this comment.
How portable is this out of interest?
There was a problem hiding this comment.
tolist says it converts NumPy scalars to Python scalars, and it sounds like a Python float is all but guaranteed to be an IEEE 754 double (also here). I know the standard doesn't specify everything, so maybe that's not enough to guarantee portability, but hopefully it's good enough for the precision we look for in the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Toward gh-20544
What does this implement/fix?
Adds array API support to
tvar,tstd, andtsem.