MAINT: Remove usages of np.row_stack and np.in1d #19110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtsokol
commented
Aug 22, 2023
| @@ -450,17 +450,17 @@ def _onenormest_core(A, AT, t, itmax): | |||
| if t > 1: | |||
| # (5) | |||
| # Break if the most promising t vectors have been visited already. | |||
| if np.in1d(ind[:t], ind_hist).all(): | |||
| if np.isin(ind[:t], ind_hist).all(): | |||
There was a problem hiding this comment.
Looking through this code, ind is 1-dimentional so np.in1d should be replaceable by np.isin without .ravel().
tylerjereddy
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ngoldbaum,
This PR addresses changes present in numpy/numpy#24445.