MAINT: Use lazy_loader for lazy loading of submodules#596
Merged
SimonHeybrock merged 10 commits intomainfrom Feb 4, 2025
Merged
MAINT: Use lazy_loader for lazy loading of submodules#596SimonHeybrock merged 10 commits intomainfrom
SimonHeybrock merged 10 commits intomainfrom
Conversation
MAINT: Use lazy_loader for lazy loading of submodules
nvaytet
reviewed
Jan 28, 2025
| # Run 'tox -e deps' after making changes here. This will update requirement files. | ||
| # Make sure to list one dependency per line. | ||
| dependencies = [ | ||
| "lazy_loader", |
Member
There was a problem hiding this comment.
I think Mantid tests are failing because you also need to add lazy_loader to the .buildconfig file?
Member
Author
|
@MridulS Docs builds are failing, can you have a look? ---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
Cell In[9], line 2
1 wavelength_graph_monitor = {
----> 2 **scn.conversion.graph.beamline.beamline(scatter=False),
3 **scn.conversion.graph.tof.elastic_wavelength('tof'),
4 }
File ~/micromamba/envs/ubuntu-latest/lib/python3.10/site-packages/lazy_loader/__init__.py:94, in attach.<locals>.__getattr__(name)
92 return attr
93 else:
---> 94 raise AttributeError(f"No {package_name} attribute {name}")
AttributeError: No scippneutron attribute conversion |
Member
Author
|
Thanks @MridulS, latest changes LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is @MridulS change from #595 +
tox -e deps.Fixes #594.