8000 Remove frame unwrapping and WFM code by nvaytet · Pull Request #592 · scipp/scippneutron · GitHub
[go: up one dir, main page]
Skip to content

Remove frame unwrapping and WFM code#592

Merged
nvaytet merged 6 commits intomainfrom
remove-unwrap
Jan 28, 2025
Merged

Remove frame unwrapping and WFM code#592
nvaytet merged 6 commits intomainfrom
remove-unwrap

Conversation

@nvaytet
Copy link
Member
@nvaytet nvaytet commented Jan 22, 2025

This code is moving to essreduce: see scipp/essreduce#163

@nvaytet nvaytet marked this pull request as ready for review January 23, 2025 13:33
@nvaytet nvaytet requested a review from SimonHeybrock January 23, 2025 13:33
@nvaytet
Copy link
Member Author
nvaytet commented Jan 23, 2025

Don't know if we want to keep the fakes. Right now they were only used in the unwrap/wfm tests which are gone.

@SimonHeybrock
Copy link
Member
SimonHeybrock commented Jan 23, 2025

Don't know if we want to keep the fakes. Right now they were only used in the unwrap/wfm tests which are gone.

I think they can be removed? Where they also added in essreduce?

@nvaytet
Copy link
Member Author
nvaytet commented Jan 27, 2025

I think they can be removed? Where they also added in essreduce?

Not exactly. The FakeBeamlineEss was moved over, but not the FakeBeamline you initially created. Also, the choppers were not moved, I made some new ones which are using DiskChopper instead of tof.chopper_cascade.Chopper.

@SimonHeybrock
Copy link
Member
SimonHeybrock commented Jan 28, 2025

Do I understand correctly that your last commit does remove them now?

@nvaytet
Copy link
Member Author
nvaytet commented Jan 28, 2025

Yes, I removed them.
I'm of the opinion that it's ok to remove, but I thought we could revert if you prefered to keep them.

@nvaytet nvaytet merged commit 167d70f into main Jan 28, 2025
5 checks passed
@nvaytet nvaytet deleted the remove-unwrap branch January 28, 2025 13:24
@nvaytet
Copy link
Member Author
nvaytet commented Jan 31, 2025

I think I forgot to remove the dependency on tof...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimonHeybrock SimonHeybrock SimonHeybrock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nvaytet @SimonHeybrock
0