This repository was archived by the owner on Feb 28, 2024. It is now read-only.
[MRG] Fix bug with categorical spaces with different types of ca… #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged on advice of @holgern |
vakker
pushed a commit
to vakker/scikit-optimize
that referenced
this pull request
Jan 14, 2020
…ikit-optimize#752) * Fix bug with categorical spaces with different types of categories * fix for python2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4CD6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #704
The problem happened with categorical domains with different data types, like [['a', 'b'], [True, False]].
When the space is categorical the transformer is an identity, so the data keep their type. When stacking different types into a numpy array, they all become strings, losing their types.
The identity transformer is now able to translate everything into a string and then transform back into the original data type.
However, mixed categories like [['a', True]] are (still) not supported.