8000 MAINT compatibility with scikit-learn 0.22 by glemaitre · Pull Request #617 · scikit-learn-contrib/imbalanced-learn · GitHub
[go: up one dir, main page]
Skip to content
10000

MAINT compatibility with scikit-learn 0.22 #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Oct 31, 2019
Merged

MAINT compatibility with scikit-learn 0.22 #617

merged 37 commits into from
Oct 31, 2019

Conversation

glemaitre
Copy link
Member
@glemaitre glemaitre commented Oct 29, 2019 •
edited
Loading

closes #616

@codecov
Copy link
codecov bot commented Oct 29, 2019 •
edited
Loading

Codecov Report

Merging #617 into master will decrease coverage by 0.68%.
The diff coverage is 98.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
- Coverage   98.92%   98.23%   -0.69%     
==========================================
  Files          85       83       -2     
  Lines        5310     4709     -601     
==========================================
- Hits         5253     4626     -627     
- Misses         57       83      +26
Impacted Files Coverage Δ
imblearn/utils/__init__.py 100% <ø> (ø) ⬆️
imblearn/under_sampling/__init__.py 100% <ø> (ø) ⬆️
...rn/under_sampling/_prototype_selection/__init__.py 100% <ø> (ø) ⬆️
imblearn/metrics/__init__.py 100% <ø> (ø) ⬆️
imblearn/datasets/tests/test_imbalance.py 100% <ø> (ø) ⬆️
imblearn/under_sampling/base.py 100% <100%> (ø) ⬆️
imblearn/over_sampling/tests/test_adasyn.py 100% <100%> (ø) ⬆️
imblearn/utils/tests/test_deprecation.py 100% <100%> (ø) ⬆️
imblearn/over_sampling/tests/test_smote.py 100% <100%> (ø) ⬆️
imblearn/keras/__init__.py 100% <100%> (ø) ⬆️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbe3820...034270f. Read the comment docs.

@glemaitre glemaitre changed the title DOC issue compiling documentation MAINT compatibility with scikit-learn 0.22 Oct 30, 2019
@pep8speaks
Copy link
pep8speaks commented Oct 31, 2019 •
edited
Loading

Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 47:1: E402 module level import not at top of file

Comment last updated at 2019-10-31 16:18:08 UTC

< 8000 a class="author Link--primary text-bold" data-test-selector="pr-timeline-events-commit-actor-profile-link" data-hovercard-type="user" data-hovercard-url="/users/glemaitre/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/glemaitre">glemaitre added 6 commits October 31, 2019 18:12
@lgtm-com
Copy link
lgtm-com bot commented Oct 31, 2019

This pull request fixes 7 alerts when merging e31c6c6 into bbe3820 - view on LGTM.com

fixed alerts:

  • 7 for Unused import

@lgtm-com
Copy link
lgtm-com bot commented Oct 31, 2019

This pull request fixes 7 alerts when merging 3603cdf into bbe3820 - view on LGTM.com

fixed alerts:

  • 7 for Unused import

@glemaitre glemaitre merged commit 7032dcb into scikit-learn-contrib:master Oct 31, 2019
@lgtm-com
Copy link
lgtm-com bot commented Oct 31, 2019

This pull request fixes 7 alerts when merging 034270f into bbe3820 - view on LGTM.com

fixed alerts:

  • 7 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of private API will break with scikit-learn 0.22
2 participants
@glemaitre @pep8speaks
0