8000 [MRG + 1] Improve the output of example plot_iris.py after matplotlib2.0 by qinhanmin2014 · Pull Request #9541 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG + 1] Improve the output of example plot_iris.py after matplotlib2.0 #9541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2017
Merged

[MRG + 1] Improve the output of example plot_iris.py after matplotlib2.0 #9541

merged 2 commits into from
Aug 15, 2017

Conversation

qinhanmin2014
Copy link
Member
@qinhanmin2014 qinhanmin2014 commented Aug 13, 2017 •
edited
Loading

Reference Issue

part of #8364
note that the plot in 0.18(before matplotlib2.0) is also not good so I also modify some other things

What does this implement/fix? Explain your changes.

Below are the results from Circle CI
new version:
sphx_glr_plot_iris_0011
old version in 0.19/dev:
sphx_glr_plot_iris_0012
old version in 0.18:
sphx_glr_plot_iris_0013

@qinhanmin2014 qinhanmin2014 changed the title [WIP] Improve the output of example plot_iris.py after matplotlib2.0 [MRG] Improve the output of example plot_iris.py after matplotlib2.0 Aug 13, 2017
@qinhanmin2014 qinhanmin2014 mentioned this pull request Aug 13, 2017
Closed
@amueller
Copy link
Member

Cool. Can you check if the new colors you chose work for people with red-green color blindness?

@qinhanmin2014
Copy link
Member Author

@amueller Thanks. I use vischeck to check it, the result seems to be OK (RdYlBu is also used in similar examples like plot_forest_iris.html)
vc_5j5iun_sim

@amueller amueller changed the title [MRG] Improve the output of example plot_iris.py after matplotlib2.0 [MRG + 1] Improve the output of example plot_iris.py after matplotlib2.0 Aug 15, 2017
@amueller
Copy link
Member

thanks! LGTM

@jnothman
Copy link
Member

LGTM

@jnothman jnothman merged commit cb16003 into scikit-learn:master Aug 15, 2017
@jnothman
Copy link
Member

Thanks, @qinhanmin2014

@qinhanmin2014 qinhanmin2014 deleted the my-feature-3 branch August 17, 2017 02:36
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@qinhanmin2014 @paulha
DOC Improve the output of example plot_iris.py after matplotlib2.0 (s…
3626626 
…cikit-learn#9541)
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
@qinhanmin2014 @AishwaryaRK
DOC Improve the output of example plot_iris.py after matplotlib2.0 (s…
1258f6c 
…cikit-learn#9541)
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Aug 30, 2017
@qinhanmin2014 @jnothman
DOC Improve the output of example plot_iris.py after matplotlib2.0 (s…
7fd7b49 
…cikit-learn#9541)
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@qinhanmin2014 @maskani-moh
DOC Improve the output of example plot_iris.py after matplotlib2.0 (s…
ad24ef0 
…cikit-learn#9541)
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@qinhanmin2014
DOC Improve the output of example plot_iris.py after matplotlib2.0 (s…
21f1db1 
…cikit-learn#9541)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qinhanmin2014 @amueller @jnothman
0