8000 [MRG] DOC Correct what's new for #9108 by qinhanmin2014 · Pull Request #9501 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] DOC Correct what's new for #9108 #9501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2017
Merged

[MRG] DOC Correct what's new for #9108 #9501

merged 1 commit into from
Aug 6, 2017

Conversation

qinhanmin2014
Copy link
Member

Reference Issue

What does this implement/fix? Explain your changes.

It should be included in bug fix, not enhancement.

Any other comments?

@jnothman Sorry for the silly mistake.

jnothman
jnothman reviewed Aug 6, 2017
View reviewed changes
Copy link
Member
@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Thanks for checking. I find quality assurance for what's new is pretty hard... I think that splitting it into more files might help, but I'm not sure how granular to go with that.

doc/whats_new/0.19/fix/decomposition-9108.rst might be excessive.

@jnothman jnothman merged commit 8f53f70 into scikit-learn:master Aug 6, 2017
@qinhanmin2014 qinhanmin2014 deleted the my-feature-1 branch August 6, 2017 05:55
jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Aug 6, 2017
@qinhanmin2014 @jnothman
DOC Correct what's new for scikit-learn#9108 (scikit-learn#9501)
8d7396c
@qinhanmin2014 qinhanmin2014 restored the my-feature-1 branch August 7, 2017 08:50
@qinhanmin2014 qinhanmin2014 deleted the my-feature-1 branch August 7, 2017 08:52
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@qinhanmin2014 @dmohns
DOC Correct what's new for scikit-learn#9108 (scikit-learn#9501)
1161541
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@qinhanmin2014 @dmohns
DOC Correct what's new for scikit-learn#9108 (scikit-learn#9501)
ec61b48
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@qinhanmin2014 @paulha
DOC Correct what's new for scikit-learn#9108 (scikit-learn#9501)
d468843
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
@qinhanmin2014 @AishwaryaRK
DOC Correct what's new for scikit-learn#9108 (scikit-learn#9501)
c1def80
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@qinhanmin2014 @maskani-moh
DOC Correct what's new for scikit-learn#9108 (scikit-learn#9501)
68025be
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@qinhanmin2014
DOC Correct what's new for scikit-learn#9108 (scikit-learn#9501)
ff7c280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman left review comm 4D90 ents

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qinhanmin2014 @jnothman
0