-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[MRG] Multimetric GridSearch - Memoize prediction results (and address some previous comments) #9326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[MRG] Multimetric GridSearch - Memoize prediction results (and address some previous comments) #9326
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d3ce2ad
Use a def as it is pickle-able
raghavrv 54d5341
Address Joel's comments
raghavrv e7e9125
Merge branch 'master' into multimetric_part2
raghavrv 2e5b729
Try memoizing predict / decicion_function calls
raghavrv 18d3549
TST memoizing of the predictions when non-default scoring is used
raghavrv e45b154
Add predict_proba, predict_log_proba and wrap all estimators
raghavrv b6b3994
Fix travis
raghavrv 7c0ed54
Undo the changes in model_evaluation.rst
raghavrv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No predict_proba or predict_log_proba? Are you these call decidion_function internally? Probabilistic non-linear predictors will be among those most benefiting from memoization, and I don't think they tend to implement decision_function.