8000 [MRG] COSMIT Remove unused parameters in private functions by jnothman · Pull Request #9310 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] COSMIT Remove unused parameters in private functions #9310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2017
Merged

[MRG] COSMIT Remove unused parameters in private functions #9310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77aee38
Remove unused parameter
jnothman Jul 10, 2017
2dad9d0
COSMIT another unused parameter
jnothman Jul 10, 2017
4e9c4a5
COSMIT another unused parameter
jnothman Jul 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions sklearn/datasets/kddcup99.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,18 +222,14 @@ def fetch_kddcup99(subset=None, data_home=None, shuffle=False,
return Bunch(data=data, target=target)


def _fetch_brute_kddcup99(subset=None, data_home=None,
def _fetch_brute_kddcup99(data_home=None,
download_if_missing=True, random_state=None,
shuffle=False, percent10=True):

"""Load the kddcup99 dataset, downloading it if necessary.

Parameters
----------
subset : None, 'SA', 'SF', 'http', 'smtp'
To return the corresponding classical subsets of kddcup 99.
If None, return the entire kddcup 99 dataset.

data_home : string, optional
Specify another download and cache folder for the datasets. By default
all scikit-learn data is stored in '~/scikit_learn_data' subfolders.
Expand Down
2 changes: 1 addition & 1 deletion sklearn/model_selection/_split.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ class StratifiedKFold(_BaseKFold):
def __init__(self, n_splits=3, shuffle=False, random_state=None):
super(StratifiedKFold, self).__init__(n_splits, shuffle, random_state)

def _make_test_folds(self, X, y=None, groups=None):
def _make_test_folds(self, X, y=None):
if self.shuffle:
rng = check_random_state(self.random_state)
else:
Expand Down
2 changes: 1 addition & 1 deletion sklearn/neural_network/multilayer_perceptron.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,7 @@ def partial_fit(self):
% self.solver)
return self._partial_fit

def _partial_fit(self, X, y, classes=None):
def _partial_fit(self, X, y):
return self._fit(X, y, incremental=True)

def _predict(self, X):
Expand Down
0