[MRG] Bayesian regression model dtype consistency #9087
Closed
Conversation<
8000
/h2>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Henley13
changed the title
Bayesian regression model dtype consistency
[WIP] Bayesian regression model dtype consistency
Jun 9, 2017
Member
The tests are failing.
Henley13
changed the title
[WIP] Bayesian regression model dtype consistency
[MRG] Bayesian regression model dtype consistency
Jun 23, 2017
Contributor
Author
@GaelVaroquaux Ping
raghavrv
approved these changes
Jun 28, 2017
Member
raghavrv
left a comment
There was a problem hiding this comment.
Thanks! This looks good to me, pending minor comments. :)
assert X.dtype == dtype
assert model.coef_.dtype == X.dtype
assert y_mean.dtype == X.dtype
assert y_std.dtype == X.dtype
Member
There was a problem hiding this comment.
could you also add a line testing dtype of predict?
ard_64.fit(X_64, y_64)
assert_array_almost_equal(br_32.coef_, br_64.coef_, decimal=5)
assert_array_almost_equal(ard_32.coef_, ard_64.coef_, decimal=5)
Member
There was a problem hiding this comment.
same here too. could you test it for the output of predict too?
Member
Can you please address the comments and fix the merge conflicts? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The tests are failing. |
Contributor
Author
|
@GaelVaroquaux Ping |
raghavrv
approved these changes
Jun 28, 2017
Member
There was a problem hiding this comment.
Thanks! This looks good to me, pending minor comments. :)
| assert X.dtype == dtype | ||
| assert model.coef_.dtype == X.dtype | ||
| assert y_mean.dtype == X.dtype | ||
| assert y_std.dtype == X.dtype |
Member
There was a problem hiding this comment.
could you also add a line testing dtype of predict?
| ard_64.fit(X_64, y_64) | ||
|
|
||
| assert_array_almost_equal(br_32.coef_, br_64.coef_, decimal=5) | ||
| assert_array_almost_equal(ard_32.coef_, ard_64.coef_, decimal=5) |
Member
There was a problem hiding this comment.
same here too. could you test it for the output of predict too?
Member
|
Can you please address the comments and fix the merge conflicts? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Works on #11000
What does this implement/fix? Explain your changes.
Avoids Bayesian Regression to aggressively cast the data to np.float64 when np.float32 is supplied.
Any other comments?