[MRG+1] fix biclustering API #9053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vene
8000
reviewed
Jun 8, 2017
doc/whats_new.rst
Outdated
| @@ -405,6 +405,10 @@ API changes summary | |||
| has been renamed to ``n_components`` and will be removed in version 0.21. | |||
| :issue:`8922` by :user:Attractadore | |||
|
|
|||
| - :class:`cluster.bicluster.SpectralCoClustering` and | |||
| :class:`cluster.bicluster.SpectralBiclustering` now accept ``y`` in fit | |||
| and return ``self``. :issue:`6126` by `Andreas Müller`_. | |||
There was a problem hiding this comment.
this PR has nothing about returning self.
don't mention returning self in whatsnew as that's already fixed in master
7d61b56 to
c4fa5d7
Compare
|
@vene removed and restricted scope of the PR |
|
LGTM. +1 for merge |
|
thanks @amueller |
|
@amueller could the scope of this pr have been any more restricted? 😛 |
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
don't mention returning self in whatsnew as that's already fixed in master
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
don't mention returning self in whatsnew as that's already fixed in master
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
don't mention returning self in whatsnew as that's already fixed in master
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
don't mention returning self in whatsnew as that's already fixed in master
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
don't mention returning self in whatsnew as that's already fixed in master
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
don't mention returning self in whatsnew as that's already fixed in master
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
don't mention returning self in whatsnew as that's already fixed in master
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
don't mention returning self in whatsnew as that's already fixed in master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6126
Replaces and closes #6141.