[MRG+1] DOC clarify OneClassSVM decision_function docstring #9048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
reviewed
Jun 8, 2017
sklearn/svm/classes.py
Outdated
| def decision_function(self, X): | ||
| """Distance of the samples X to the separating hyperplane. | ||
| """Signed distance to the separating hyperplane: positive if inlier, | ||
| negative if outlier. |
Member
There was a problem hiding this comment.
following https://www.python.org/dev/peps/pep-0257/ the first line should be short without line break.
I would write:
"""Signed distance to the separating hyperplane
Signed distance is positive for an inlier and negative for out outlier.
...
Contributor
Author
|
Thanks @agramfort |
Member
|
thanks @albertcthomas |
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jun 8, 2017
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
…earn#9048) * clarify ocsvm decision_function docstring * take into account agramfort comment
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jun 19, 2017
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jun 29, 2017
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jul 19, 2017
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jul 29, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…earn#9048) * clarify ocsvm decision_function docstring * take into account agramfort comment
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
…earn#9048) * clarify ocsvm decision_function docstring * take into account agramfort comment
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
…earn#9048) * clarify ocsvm decision_function docstring * take into account agramfort comment
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Aug 14, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…earn#9048) * clarify ocsvm decision_function docstring * take into account agramfort comment
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
…earn#9048) * clarify ocsvm decision_function docstring * take into account agramfort comment
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Aug 31, 2017
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Sep 15, 2017
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Sep 25, 2017
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Oct 6, 2017
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Oct 9, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…earn#9048) * clarify ocsvm decision_function docstring * take into account agramfort comment
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Dec 4, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…earn#9048) * clarify ocsvm decision_function docstring * take into account agramfort comment
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Apr 23, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jul 25, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Aug 22, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Oct 5, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Oct 11, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Nov 1, 2019
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jan 10, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jan 30, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jan 30, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Feb 27, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Mar 12, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Apr 17, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
May 3, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
May 30, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jul 5, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jul 5, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Aug 5, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Oct 15, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Nov 28, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Dec 12, 2020
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Feb 25, 2021
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Feb 25, 2021
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Mar 27, 2021
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jun 15, 2021
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jul 23, 2021
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Nov 10, 2021
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
May 15, 2022
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jun 14, 2022
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Aug 29, 2022
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
This finishes PR #7788 and addresses issue #7713.
What does this implement/fix? Explain your changes.
Clarifies the docstring of the decision function of the
OneClassSVMsaying that positive means inlier and negative means outlier.