10000 [MRG] FIX set min_impurity_split to None in gradient boosting estimator by glemaitre · Pull Request #8789 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] FIX set min_impurity_split to None in gradient boosting estimator #8789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2017
Merged

[MRG] FIX set min_impurity_split to None in gradient boosting estimator #8789

merged 1 commit into from
Apr 25, 2017

Conversation

glemaitre
Copy link
Member

Reference Issue

Fixes #8787

What does this implement/fix? Explain your changes.

min_impurity_split was not set to None during the deprecation done during #8449

@lesteve
Copy link
Member
lesteve commented Apr 25, 2017 •
edited
Loading

On master I see the deprecation warnings for examples/ensemble/plot_gradient_boosting_regression.py and examples/ensemble/plot_gradient_boosting_oob.py although min_impurity_split is not set.

With this PR the deprecation warnings are gone.

LGTM, merging, thanks a lot!

@lesteve lesteve merged commit 676f878 into scikit-learn:master Apr 25, 2017
@raghavrv
Copy link
Member

Oops my bad. Thanks for fixing it :)

@amueller
Copy link
Member

Thanks folks, that was quick! :)

Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@glemaitre @Sundrique
FIX set min_impurity_split to None in gradient boosting estimator (sc…
91a5db3 
…ikit-learn#8789)
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@glemaitre @dmohns
FIX set min_impurity_split to None in gradient boosting estimator (sc…
7250499 
…ikit-learn#8789)
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@glemaitre @dmohns
FIX set min_impurity_split to None in gradient boosting estimator (sc…
d07e483 
…ikit-learn#8789)
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@glemaitre @NelleV
FIX set min_impurity_split to None in gradient boosting estimator (sc…
1f7de8e 
…ikit-learn#8789)
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@glemaitre @paulha
FIX set min_impurity_split to None in gradient boosting estimator (sc…
ef38b3e 
…ikit-learn#8789)
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@glemaitre @maskani-moh
FIX set min_impurity_split to None in gradient boosting estimator (sc…
edfac23 
…ikit-learn#8789)
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@glemaitre
FIX set min_impurity_split to None in gradient boosting estimator (sc…
73dc99e 
…ikit-learn#8789)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GradientBoosting warns for min_impurity_split even if not set
4 participants
@glemaitre @lesteve @raghavrv @amueller
0