[MRG] LogisticCV Score Function Fixed #8529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
reviewed
Mar 4, 2017
sklearn/linear_model/logistic.py
Outdated
| @@ -1542,6 +1542,7 @@ def fit(self, X, y, sample_weight=None): | |||
| self : object | |||
| Returns self. | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
can you remove this empty line?
amueller
reviewed
Mar 4, 2017
sklearn/linear_model/logistic.py
Outdated
| "" | ||
|
|
||
| warnings.warn('The score function always returns mean accuracy due to' | ||
| ' a bug in scikit-learn. Refer the documentation for more details.') |
There was a problem hiding this comment.
This should be indented 4 spaces. Also, I don't think this is a bug, it's more an unexpected behavior.
jnothman
reviewed
Mar 5, 2017
| """Returns the mean accuracy on given test data and labels. | ||
|
|
||
| Due to a bug in scikit-learn this method always returns mean accuracy. | ||
| This will be fixed in version 0.20. For now you can externally call the |
There was a problem hiding this comment.
Should specify how it will be "fixed". Perhaps "this will be changed to respect the scoring parameter where provided".
There was a problem hiding this comment.
@jnothman Thank you for your comment. It is my first contribution to the community and I will try my best to contribute more in the future.
|
fixed in #11192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #8274
What does this implement/fix? Explain your changes.
LogisticCV score function has been fixed due to a Scikit-Learn bug.
Any other comments?