add html-noplot and changed help message to make.bat #8524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amueller
reviewed
Mar 4, 2017
doc/make.bat
Outdated
| @@ -24,6 +24,7 @@ if "%1" == "help" ( | |||
| echo. changes to make an overview over all changed/added/deprecated items | |||
| echo. linkcheck to check all external links for integrity | |||
| echo. doctest to run all doctests embedded in the documentation if enabled | |||
| echo. html-noplot to make HTML files using Windows | |||
There was a problem hiding this comment.
It looks like the indentation is off here. Can you fix that please?
|
Done? |
|
LGTM. merging as minor :) |
|
Congrats @EFerriss, you did it!!! |
Closed
herilalaina
pushed a commit
to herilalaina/scikit-learn
that referenced
this pull request
Mar 26, 2017
* add html-noplot and help message to make.bat * changed spaces to tab in make.bat help * changed all spaces to tabs in make.bat update
massich
pushed a commit
to massich/scikit-learn
that referenced
this pull request
Apr 26, 2017
* add html-noplot and help message to make.bat * changed spaces to tab in make.bat help * changed all spaces to tabs in make.bat update
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
* add html-noplot and help message to make.bat * changed spaces to tab in make.bat help * changed all spaces to tabs in make.bat update
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
* add html-noplot and help message to make.bat * changed spaces to tab in make.bat help * changed all spaces to tabs in make.bat update
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* add html-noplot and help message to make.bat * changed spaces to tab in make.bat help * changed all spaces to tabs in make.bat update
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
* add html-noplot and help message to make.bat * changed spaces to tab in make.bat help * changed all spaces to tabs in make.bat update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
What does this implement/fix? Explain your changes.
Windows users who want to make changes to the documentation and check that the html looks correct can now run 'make html-noplot' so that it doesn't go through all of the examples, which would take a long time. The default for make without a target is still to show help (maybe that should change?), but I added a mention of html-noplot to the help message.
Any other comments?