-
-
Notifications
You must be signed in to change notification settings - Fork 26k
[MRG + 2] Deprecated comparison to string in GP #8518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM, thanks. |
LGTM as well, and seems to remove all of the warnings. It looks like appveyor is behind on the tests though. |
@Namiya for the future, please comment on an issue if you're working on it so it's easier to coordinate. |
@amueller I worked with zxcvbnius together in the sprint event. And we did comment on the issue you raised. |
Codecov Report
@@ Coverage Diff @@
## master #8518 +/- ##
==========================================
+ Coverage 95.48% 95.48% +<.01%
==========================================
Files 342 342
Lines 60913 60915 +2
==========================================
+ Hits 58160 58162 +2
Misses 2753 2753
Continue to review full report at Codecov.
|
This passes all tests so I'm merging it now. Thanks @Namiya and zxcvbnius! |
Reference Issue
Fixes #8503
What does this implement/fix? Explain your changes.
Any other comments?