8000 [MRG + 2] Deprecated comparison to string in GP by Namiya · Pull Request #8518 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

[MRG + 2] Deprecated comparison to string in GP #8518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2017

Conversation

Namiya
Copy link
Contributor
@Namiya Namiya commented Mar 4, 2017

Reference Issue

Fixes #8503

What does this implement/fix? Explain your changes.

Any other comments?

@amueller
Copy link
Member
amueller commented Mar 4, 2017

LGTM, thanks.

@amueller amueller changed the title [MRG] Deprecated comparison to string in GP [MRG + 1] Deprecated comparison to string in GP Mar 4, 2017
@jmschrei
Copy link
Member
jmschrei commented Mar 4, 2017

LGTM as well, and seems to remove all of the warnings. It looks like appveyor is behind on the tests though.

@jmschrei jmschrei changed the title [MRG + 1] Deprecated comparison to string in GP [MRG + 2] Deprecated comparison to string in GP Mar 4, 2017
@amueller
Copy link
Member
amueller commented Mar 4, 2017

@Namiya for the future, please comment on an issue if you're working on it so it's easier to coordinate.

@Namiya
Copy link
Contributor Author
Namiya commented Mar 4, 2017

@amueller I worked with zxcvbnius together in the sprint event. And we did comment on the issue you raised.

@codecov
Copy link
codecov bot commented Mar 4, 2017

Codecov Report

Merging #8518 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #8518      +/-   ##
==========================================
+ Coverage   95.48%   95.48%   +<.01%     
==========================================
  Files         342      342              
  Lines       60913    60915       +2     
==========================================
+ Hits        58160    58162       +2     
  Misses       2753     2753
Impacted Files Coverage Δ
sklearn/gaussian_process/tests/test_kernels.py 98.86% <100%> (+0.01%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdd693b...87e089f. Read the comment docs.

@jmschrei
Copy link
Member
jmschrei commented Mar 4, 2017

This passes all tests so I'm merging it now. Thanks @Namiya and zxcvbnius!

@jmschrei jmschrei merged commit 39076ff into scikit-learn:master Mar 4, 2017
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
herilalaina pushed a commit to herilalaina/scikit-learn that referenced this pull request Mar 26, 2017
massich pushed a commit to massich/scikit-learn that referenced this pull request Apr 26, 2017
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated comparison to string in GP
3 participants
0