[MRG] Modify Svm examples for matplotlibv2 comp #8456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `edgecolors` attribute in scatter plot for better visualization in matplotlib version 2 Issue: #8364
Add `edgecolors` attribute to scatter plot for better visualization in matplotlib version 2 Issue: #8364
Add `edgecolors` attribute to scatter plot for better visualization. Issue: #8364
Add `edgecolors` attribute to scatter plot for better visualization. Issue: #8364
Add `edgecolors` attribute to scatter plot for better visualization. Issue: #8364
Add `edgecolors` attribute to scatter plot for better visualization. Issue: #8364
Add `edgecolors` attribute to scatter plot for matplotlib version 2 compatibility Issue: #8364
Remove extra white space. Issue: #8364
Codecov Report
@@ Coverage Diff @@
## master #8456 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 342 342
Lines 60907 60907
=======================================
Hits 58154 58154
Misses 2753 2753Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #8456 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 342 342
Lines 60907 60907
=======================================
Hits 58154 58154
Misses 2753 2753Continue to review full report at Codecov.
|
|
In |
|
Otherwise LGTM |
|
The figure in |
|
Actually the problem is in embedding of plot in html. Whenever I run the script in python console it runs fine in both scenario (matplotlib v2 and matplotlib older version (v 0.15)) but when I ran the same in Ipython notebook the visualisation size of the plot is not same ( matplotlib v2 plot looks little smaller in size than older version ) . |
|
Could that also be an issue of updated sphinx-gallery? Btw I feel like the last one didn't re 10000 ally need "fixing" but I'm fine with it. |
|
LGTM, I like incremental improvements. |
Closed
herilalaina
pushed a commit
to herilalaina/scikit-learn
that referenced
this pull request
Mar 26, 2017
* Modify plot_custom_kernel for matplotlib v2 comp Add `edgecolors` attribute in scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_oneclass.py for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_rbf_parameters for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_separating_hyperplane_unbalanced for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plo_svm_kernels for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_margin for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_nonlinear for matplotlib v2 Add `edgecolors` attribute to scatter plot for matplotlib version 2 compatibility Issue: scikit-learn#8364 * Modify file for remove flake8 error Remove extra white space. Issue: scikit-learn#8364
massich
pushed a commit
to massich/scikit-learn
that referenced
this pull request
Apr 26, 2017
* Modify plot_custom_kernel for matplotlib v2 comp Add `edgecolors` attribute in scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_oneclass.py for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_rbf_parameters for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_separating_hyperplane_unbalanced for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plo_svm_kernels for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_margin for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_nonlinear for matplotlib v2 Add `edgecolors` attribute to scatter plot for matplotlib version 2 compatibility Issue: scikit-learn#8364 * Modify file for remove flake8 error Remove extra white space. Issue: scikit-learn#8364
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
* Modify plot_custom_kernel for matplotlib v2 comp Add `edgecolors` attribute in scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_oneclass.py for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_rbf_parameters for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_separating_hyperplane_unbalanced for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plo_svm_kernels for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_margin for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_nonlinear for matplotlib v2 Add `edgecolors` attribute to scatter plot for matplotlib version 2 compatibility Issue: scikit-learn#8364 * Modify file for remove flake8 error Remove extra white space. Issue: scikit-learn#8364
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
* Modify plot_custom_kernel for matplotlib v2 comp Add `edgecolors` attribute in scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_oneclass.py for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_rbf_parameters for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_separating_hyperplane_unbalanced for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plo_svm_kernels for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_margin for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_nonlinear for matplotlib v2 Add `edgecolors` attribute to scatter plot for matplotlib version 2 compatibility Issue: scikit-learn#8364 * Modify file for remove flake8 error Remove extra white space. Issue: scikit-learn#8364
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
* Modify plot_custom_kernel for matplotlib v2 comp Add `edgecolors` attribute in scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_oneclass.py for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_rbf_parameters for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_separating_hyperplane_unbalanced for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plo_svm_kernels for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_margin for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_nonlinear for matplotlib v2 Add `edgecolors` attribute to scatter plot for matplotlib version 2 compatibility Issue: scikit-learn#8364 * Modify file for remove flake8 error Remove extra white space. Issue: scikit-learn#8364
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
* Modify plot_custom_kernel for matplotlib v2 comp Add `edgecolors` attribute in scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_oneclass.py for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization in matplotlib version 2 Issue: scikit-learn#8364 * Modify plot_rbf_parameters for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_separating_hyperplane_unbalanced for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plo_svm_kernels for matplotlib v2 Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_margin for matplotlib v2 comp Add `edgecolors` attribute to scatter plot for better visualization. Issue: scikit-learn#8364 * Modify plot_svm_nonlinear for matplotlib v2 Add `edgecolors` attribute to scatter plot for matplotlib version 2 compatibility Issue: scikit-learn#8364 * Modify file for remove flake8 error Remove extra white space. Issue: scikit-learn#8364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
#8364
What does this implement/fix? Explain your changes.
Add
edgecolorsattribute in scatter plot.Any other comments?
Please verify all example plots using following links :
Stable version
Dev version
PR version
Stable version
Dev version
PR version
Stable version
Dev version
PR version
Stable version
Dev version
PR version
Stable version
Dev version
PR version
Stable version
Dev version
PR version
Stable version
Dev version
PR version