8000 [MRG] Fix Parameters in tutorials by anshbansal · Pull Request #8345 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content
8000

[MRG] Fix Parameters in tutorials #8345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2017
Merged

[MRG] Fix Parameters in tutorials #8345

merged 3 commits into from
Feb 23, 2017

Conversation

anshbansal
Copy link
Contributor
@anshbansal anshbansal commented Feb 12, 2017 •
edited
Loading

Reference Issue

Tutorial contained incorrect parameters

What does this implement/fix? Explain your changes.

Documentation fix

Any other comments?

No

8000 @anshbansal anshbansal changed the title [MRG] Fix Parameters of StratifiedKFold in docs [WIP] Fix Parameters of StratifiedKFold in docs Feb 12, 2017
@anshbansal anshbansal changed the title [WIP] Fix Parameters of StratifiedKFold in docs [MRG] Fix Parameters in tutorials Feb 12, 2017
TomDLT
TomDLT requested changes Feb 13, 2017
View reviewed changes
Copy link
Member
@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix !

Can you also update n_iter to n_splits in ShuffleSplit below?
And maybe add the same info for StratifiedShuffleSplit and GroupShuffleSplit?

@lesteve
Copy link
Member
lesteve commented Feb 14, 2017 •
edited
Loading

Can you also update n_iter to n_splits in ShuffleSplit below?
And maybe add the same info for StratifiedShuffleSplit and GroupShuffleSplit?

+1

Also LeavePGroup parameter is called n_groups

@codecov
Copy link
codecov bot commented Feb 23, 2017

Codecov Report

Merging #8345 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8345   +/-   ##
=======================================
  Coverage   94.74%   94.74%           
=======================================
  Files         342      342           
  Lines       60735    60735           
=======================================
  Hits        57543    57543           
  Misses       3192     3192

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf5006...f5bc5f4. Read the comment docs.

1 similar comment
@codecov
Copy link
codecov bot commented Feb 23, 2017

Codecov Report

Merging #8345 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8345   +/-   ##
=======================================
  Coverage   94.74%   94.74%           
=======================================
  Files         342      342           
  Lines       60735    60735           
=======================================
  Hits        57543    57543           
  Misses       3192     3192

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf5006...f5bc5f4. Read the comment docs.

@jnothman
Copy link
Member

Made some changes sought by @TomDLT and @lesteve so this can be merged rather than forgotten. Thanks @anshbansal

@jnothman jnothman merged commit 2d0bce7 into scikit-learn:master Feb 23, 2017
@lesteve
Copy link
Member
lesteve commented Feb 23, 2017

Thanks @jnothman!

sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
@anshbansal @sergeyf
[MRG] Fix Parameters in tutorials (scikit-learn#8345)
c22a73e
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Closed
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@anshbansal @Sundrique
[MRG] Fix Parameters in tutorials (scikit-learn#8345)
28dd4b0
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@anshbansal @NelleV
[MRG] Fix Parameters in tutorials (scikit-learn#8345)
a0ccedc
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@anshbansal @paulha
[MRG] Fix Parameters in tutorials (scikit-learn#8345)
47366b4
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@anshbansal @maskani-moh
[MRG] Fix Parameters in tutorials (scikit-learn#8345)
ef9d37c
lemonlaug pushed a commit to lemonlaug/scikit-learn that referenced this pull request Jan 6, 2021
@anshbansal
[MRG] Fix Parameters in tutorials (scikit-learn#8345)
bdce980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomDLT TomDLT TomDLT requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anshbansal @lesteve @jnothman @TomDLT
0