change kfold to k_fold for consistency;fix example #8330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfold would result in a NameError in that specific codeblock. Rename kfold to k_fold to keep it consistent with other instances of KFold in the other snippets.
lesteve
reviewed
Feb 9, 2017
| @@ -70,7 +70,7 @@ This example shows an example usage of the ``split`` method. | |||
|
|
|||
| The cross-validation can then be performed easily:: | |||
|
|
|||
| >>> kfold = KFold(n_splits=3) | |||
| >>> k_fold = KFold(n_splits=3) | |||
There was a problem hiding this comment.
Good catch. Actually I am wondering whether this line should not be removed since k_fold is already defined a few lines above here.
There was a problem hiding this comment.
That's also fair game. Since the snippets below the one referenced for cross_val_score don't create another KFold instance.
There was a problem hiding this comment.
I removed the line and I'll wait for the CI. I'll merge this one they come back green.
|
Merging, thanks a lot! |
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
lemonlaug
pushed a commit
to lemonlaug/scikit-learn
that referenced
this pull request
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
What does this implement/fix? Explain your changes.
kfold would result in a NameError in that specific codeblock. (in the documentation)
Rename kfold to k_fold to keep it consistent with other instances of KFold in the other snippets.
Any other comments?