8000 [MRG+1] Enable codecov for coverage report by rishikksh20 · Pull Request #8311 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

[MRG+1] Enable codecov for coverage report #8311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2017
Merged

[MRG+1] Enable codecov for coverage report #8311

merged 2 commits into from
Feb 8, 2017

Conversation

rishikksh20
Copy link
Contributor

Reference Issue

#8305

What does this implement/fix? Explain your changes.

Replace coveralls from codecov

Any other comments?

@rishikksh20 rishikksh20 changed the title [WIP] Enable codecov for coverage report [MRG] Enable codecov for coverage report Feb 7, 2017
Replacing code coverage tool from coveralls to codecov.

Issue: #8305
Replace coveralls badge from codecov badge
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@db74d19). Click here to learn what that means.

@@            Coverage Diff            @@
##             master    #8311   +/-   ##
=========================================
  Coverage          ?   94.73%           
=========================================
  Files             ?      342           
  Lines             ?    60672           
  Branches          ?        0           
=========================================
  Hits              ?    57480           
  Misses            ?     3192           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db74d19...92bb108. Read the comment docs.

@jnothman
Copy link
Member
jnothman commented Feb 8, 2017

I'm willing to give this a go. +1 for merge

@jnothman jnothman changed the title [MRG] Enable codecov for coverage report [MRG+1] Enable codecov for coverage report Feb 8, 2017
@GaelVaroquaux
Copy link
Member

+1 on my side too. Merging.

I wonder if I don't have to do something on the github side to enable codecov in the CI status, but I didn't see it on a quick look.

@GaelVaroquaux GaelVaroquaux merged commit 7721359 into scikit-learn:master Feb 8, 2017
@lesteve
Copy link
Member
lesteve commented Feb 8, 2017

I wonder if I don't have to do something on the github side to enable codecov

I bet one of the maintainer has to do something to set-up codecov indeed. I'll look at it today.

@GaelVaroquaux
Copy link
Member
GaelVaroquaux commented Feb 8, 2017 via email

@lesteve
Copy link
Member
lesteve commented Feb 8, 2017

It should work now.

Confirmed: https://codecov.io/gh/scikit-learn/scikit-learn

@lesteve
Copy link
Member
lesteve commented Feb 8, 2017

@rishikksh20 please use "Fix #issueNumber" in your next PR description, this way the associated issue gets closed automatically when the PR is merged.

@rishikksh20 rishikksh20 deleted the sklearn_codecov_patch branch February 8, 2017 07:53
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
* Replace coveralls from codecov for coverage report

Replacing code coverage tool from coveralls to codecov.

Issue: scikit-learn#8305

* Add codecov badge for coverage report

Replace coveralls badge from codecov badge
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
* Replace coveralls from codecov for coverage report

Replacing code coverage tool from coveralls to codecov.

Issue: scikit-learn#8305

* Add codecov badge for coverage report

Replace coveralls badge from codecov badge
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
* Replace coveralls from codecov for coverage report

Replacing code coverage tool from coveralls to codecov.

Issue: scikit-learn#8305

* Add codecov badge for coverage report

Replace coveralls badge from codecov badge
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
* Replace coveralls from codecov for coverage report

Replacing code coverage tool from coveralls to codecov.

Issue: scikit-learn#8305

* Add codecov badge for coverage report

Replace coveralls badge from codecov badge
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
* Replace coveralls from codecov for coverage report

Replacing code coverage tool from coveralls to codecov.

Issue: scikit-learn#8305

* Add codecov badge for coverage report

Replace coveralls badge from codecov badge
lemonlaug pushed a commit to lemonlaug/scikit-learn that referenced this pull request Jan 6, 2021
* Replace coveralls from codecov for coverage report

Replacing code coverage tool from coveralls to codecov.

Issue: scikit-learn#8305

* Add codecov badge for coverage report

Replace coveralls badge from codecov badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0