10000 additional fixes to 20 newsgroups to prevent TypeError by BasilBeirouti · Pull Request #8204 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

additional fixes to 20 newsgroups to prevent TypeError #8204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2017
Merged

additional fixes to 20 newsgroups to prevent TypeError #8204

merged 3 commits into from
Jan 15, 2017

Conversation

BasilBeirouti
Copy link
Contributor

pipeline was not created properly (both classes had .predict) causing
TypeError to be thrown.

Also removed incorrect keyword argument loss=“l2” for LinearSVC

…gument

pipeline was not created properly (both classes had .predict) causing
TypeError to be thrown.

Also removed incorrect keyword argument loss=“l2” for LinearSVC
Copy link
Member
@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jnothman jnothman merged commit 3dc8d2f into scikit-learn:master Jan 15, 2017
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
…arn#8204)

* removed stray space in '__main__ '

* fixed pipeline bug causing TypeError and removed incorrect keyword argument

pipeline was not created properly (both classes had .predict) causing
TypeError to be thrown.

Also removed incorrect keyword argument loss=“l2” for LinearSVC
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
…arn#8204)

* removed stray space in '__main__ '

* fixed pipeline bug causing TypeError and removed incorrect keyword argument

pipeline was not created properly (both classes had .predict) causing
TypeError to be thrown.

Also removed incorrect keyword argument loss=“l2” for LinearSVC
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
…arn#8204)

* removed stray space in '__main__ '

* fixed pipeline bug causing TypeError and removed incorrect keyword argument

pipeline was not created properly (both classes had .predict) causing
TypeError to be thrown.

Also removed incorrect keyword argument loss=“l2” for LinearSVC
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
…arn#8204)

* removed stray space in '__main__ '

* fixed pipeline bug causing TypeError and removed incorrect keyword argument

pipeline was not created properly (both classes had .predict) causing
TypeError to be thrown.

Also removed incorrect keyword argument loss=“l2” for LinearSVC
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
…arn#8204)

* removed stray space in '__main__ '

* fixed pipeline bug causing TypeError and removed incorrect keyword argument

pipeline was not created properly (both classes had .predict) causing
TypeError to be thrown.

Also removed incorrect keyword argument loss=“l2” for LinearSVC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0