[MRG] Change deprecation warning for doc_topic_distr from future to present… #8146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naoyak
reviewed
Jan 2, 2017
| @@ -763,7 +763,7 @@ def perplexity(self, X, doc_topic_distr='deprecated', sub_sampling=False): | |||
|
|
|||
| doc_topic_distr : None or array, shape=(n_samples, n_topics) | |||
| Document topic distribution. | |||
| If it is None, it will be generated by applying transform on X. | |||
| This argument is deprecated and is currenly being ignored. | |||
| @@ -753,8 +753,8 @@ def perplexity(self, X, doc_topic_distr='deprecated', sub_sampling=False): | |||
| Perplexity is defined as exp(-1. * log-likelihood per word) | |||
|
|
|||
| .. versionchanged:: 0.19 | |||
| *doc_topic_distr* argument has been depricated because user no | |||
| longer has access to unnormalized distribution | |||
| *doc_topic_distr* argument has been depricated and is ignored | |||
tguillemot
approved these changes
Jan 3, 2017
naoyak
approved these changes
Apr 30, 2017
|
Seems like this should go in for 0.19, didn't realize it was still out there. @jnothman ? |
|
LGTM. Thanks for the pink, @naoyak |
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
dmohns
pushed a commit
to dmohns/scikit-learn
that referenced
this pull request
Aug 7, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
AishwaryaRK
pushed a commit
to AishwaryaRK/scikit-learn
that referenced
this pull request
Aug 29, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… tense
Reference Issue
#7992 (comment)
What does this implement/fix? Explain your changes.
Clarifies that the doc_topic_distr arguement of the perplexity method is already being ignored as of the version 0.19 release.
Any other comments?